-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes guide search when using colored chat #4125
Conversation
Your Pull Request was automatically labelled as: "✨ Fix" |
The color search was fixed here was it not? #4044 |
It was not. We aren't getting through real colored text so stripping wasn't actually doing anything. We're instead getting user friendly colored text (& - e.g. &6test) So, we're changing to pass through real colored text and strip. |
Okay that makes sense on the dough end, but what I didn't understand is why are you adding an additional strip color to the method parameter, it will call it already in the method |
Simple answer is I didn't see it getting stripped anywhere |
Fair enough, it gets stripped in the survival slimefun guides implementation |
Yee I see it now, we call the interface method but in the same class is the impl func where we strip This PR is basically just gonna be update dough then |
...main/java/io/github/thebusybiscuit/slimefun4/implementation/guide/SurvivalSlimefunGuide.java
Outdated
Show resolved
Hide resolved
5a0a945
to
8a60fe9
Compare
8a60fe9
to
76710b6
Compare
76710b6
to
2ba3e26
Compare
Quality Gate passedIssues Measures |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4125/0f9938e1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Description
Fixes guide search when using colored chat
Proposed changes
With Slimefun/dough#250 handle the ChatInput as colored text rather than user friendly (&) text.
Also pinned Spigot to resolve build issues.
Related Issues (if applicable)
N/A
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null valuesTODO