Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes guide search when using colored chat #4125

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Feb 11, 2024

Description

Fixes guide search when using colored chat

Proposed changes

With Slimefun/dough#250 handle the ChatInput as colored text rather than user friendly (&) text.

Also pinned Spigot to resolve build issues.

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

TODO

  • merge dough PR and update pom

@WalshyDev WalshyDev requested review from a team as code owners February 11, 2024 19:17
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Feb 11, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@JustAHuman-xD
Copy link
Contributor

The color search was fixed here was it not? #4044

@WalshyDev
Copy link
Member Author

The color search was fixed here was it not? #4044

It was not. We aren't getting through real colored text so stripping wasn't actually doing anything. We're instead getting user friendly colored text (& - e.g. &6test)

So, we're changing to pass through real colored text and strip.

@JustAHuman-xD
Copy link
Contributor

The color search was fixed here was it not? #4044

It was not. We aren't getting through real colored text so stripping wasn't actually doing anything. We're instead getting user friendly colored text (& - e.g. &6test)

So, we're changing to pass through real colored text and strip.

Okay that makes sense on the dough end, but what I didn't understand is why are you adding an additional strip color to the method parameter, it will call it already in the method

@WalshyDev
Copy link
Member Author

Simple answer is I didn't see it getting stripped anywhere

@JustAHuman-xD
Copy link
Contributor

Simple answer is I didn't see it getting stripped anywhere

Fair enough, it gets stripped in the survival slimefun guides implementation

@WalshyDev
Copy link
Member Author

Yee I see it now, we call the interface method but in the same class is the impl func where we strip

This PR is basically just gonna be update dough then

Sfiguz7
Sfiguz7 previously approved these changes Feb 14, 2024
@WalshyDev WalshyDev force-pushed the fix/chatcolor-issue-in-guide-search branch from 76710b6 to 2ba3e26 Compare February 16, 2024 20:41
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 0f9938e1

https://preview-builds.walshy.dev/download/Slimefun/4125/0f9938e1

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@WalshyDev WalshyDev merged commit 8666bbc into master Feb 16, 2024
18 checks passed
@WalshyDev WalshyDev deleted the fix/chatcolor-issue-in-guide-search branch February 16, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants