fix items not being able to be placed on ancient altar #4094
Conversation
|
Your Pull Request was automatically labelled as: "✨ Fix" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4094/c77b405c
|
|
Let's version this, I'd rather not bring back flicker for 1.20 and all future versions. |
| armorStand.setRemoveWhenFarAway(false); | ||
| }); | ||
| // 1.19 and below don't have the consumer method so flicker exists on these versions. | ||
| if (Slimefun.getMinecraftVersion().isBefore(MinecraftVersion.MINECRAFT_1_20)) { |
There was a problem hiding this comment.
I wish we had a isAtMost but we don't haha
|
I'm kinda confused I'll admit, I made this PR working in 1.19, I'm going to check Java docs some more cause I'm currently looking at some that say the method exists for spigot 1.19.1 at least |
|
Exists on 1.16.5 too, checked using: https://jd.andross.fr Simply search "spawn(Location" and you'll find it |
|
Discord convo for ref: https://discord.com/channels/565557184348422174/565569196218384385/1196787007125471273 |
Description
This bug apparenttly has existed for 7 months.
On 1.19.4 you are not able to place items on an ancient altar you get the following error
https://pastebin.com/87UpB46w
Proposed changes
revert 060b59d
Related Issues (if applicable)
issue reported on discord
https://canary.discord.com/channels/565557184348422174/565569196218384385/1196756895948619797
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values