Add new analytics service #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request was automatically labelled as: "🎈 Feature" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4067/115ccce5
|
J3fftw1
reviewed
Dec 21, 2023
src/main/java/io/github/thebusybiscuit/slimefun4/core/services/AnalyticsService.java
Show resolved
Hide resolved
WalshyDev
force-pushed
the
feature/analytics
branch
from
9015890
to
48fdd39
Compare
|
|
Got a base site built out for this, just seeing if we can grab the slimefun.dev domain and then I can close this out |
TheBusyBot
added
the
⚡ Merge Conflicts
WalshyDev
force-pushed
the
feature/analytics
branch
2 times, most recently
from
5696e5d
to
1f79c81
Compare
WalshyDev
removed
the
⚡ Merge Conflicts
J3fftw1
suggested changes
Feb 16, 2024
src/main/java/io/github/thebusybiscuit/slimefun4/core/services/ThreadService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/core/services/ThreadService.java
Outdated
Show resolved
Hide resolved
J3fftw1
previously approved these changes
Feb 16, 2024
Sfiguz7
requested changes
Feb 16, 2024
src/main/java/io/github/thebusybiscuit/slimefun4/core/services/AnalyticsService.java
Outdated
Show resolved
Hide resolved
WalshyDev
force-pushed
the
feature/analytics
branch
2 times, most recently
from
7983c6f
to
11a259c
Compare
WalshyDev
force-pushed
the
feature/analytics
branch
from
11a259c
to
aff9f87
Compare
J3fftw1
previously approved these changes
Feb 17, 2024
Sfiguz7
reviewed
Feb 17, 2024
src/main/java/io/github/thebusybiscuit/slimefun4/core/services/AnalyticsService.java
Outdated
Show resolved
Hide resolved
Sfiguz7
approved these changes
Feb 17, 2024
|
J3fftw1
approved these changes
Feb 17, 2024
WalshyDev
added a commit
to J3fftw1/Slimefun4
that referenced
this pull request
Feb 19, 2024
Co-authored-by: Alessio Colombo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #developers, we want some better analytic insights into Slimefun (especially for the new storage layer work in progress).
This creates a new service and adds it to our current timings.
This can be debugged with
/sf debug slimefun_analytics. Debugging will just show the JSON being sent and if the send was ignored.Users can disable in the
config.ymlatmetrics.analytics.Proposed changes
Creates a new analytics service
Related Issues (if applicable)
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null valuesStill to do