-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed vanilla sensitive blocks #4050
Conversation
Your Pull Request was automatically labelled as: "✨ Fix" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4050/b9335cdf
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praying
Description
Sensitive blocks were an issue, they were "fixed" a couple of times (#3966, #4048) and then we reverted the changes as it was a mess (#4049).
This now solves the issue for good in terms of vanilla sensitive blocks.
Proposed changes
Only drop items when BlockBreakEvent.isDropItems() is false, as otherwise we get double vanilla drops
Check around the block for sensitive blocks up until the max chained amount
Related Issues (if applicable)
Resolves #3182
Resolves #3831
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values