Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update download link #4047

Closed
wants to merge 4 commits into from

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Dec 8, 2023

Description

Update the download link in README.md to blob builds.

Proposed changes

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

@JustAHuman-xD
Copy link
Contributor

problems:

  1. Those are direct downloads compared to the previous page, idk if thats a good idea
  2. there are also download things on the wiki (which can be addressed in a separate pr) (https://github.com/Slimefun/Wiki/blob/master/pages/Installing-Slimefun.md)

@JustAHuman-xD
Copy link
Contributor

problems:

  1. Those are direct downloads compared to the previous page, idk if thats a good idea
  2. there are also download things on the wiki (which can be addressed in a separate pr) (https://github.com/Slimefun/Wiki/blob/master/pages/Installing-Slimefun.md)

The first problem is what allowed you to snipe this PR from me lol, I was trying to find a way to not do direct downloads

@ybw0014
Copy link
Contributor Author

ybw0014 commented Dec 8, 2023

the release channels are displayed together, unless walshy adds something to separately show them

@variananora
Copy link
Member

I was trying to find a way to not do direct downloads

Yeah same, when updating the ?latest Discord tag I just used DDL rather than the page. If blob.build can do something like https://blob.build/project/Slimefun4#dev or https://blob.build/project/Slimefun4#rc to auto scroll the page that would be awesome tho.

@WalshyDev
Copy link
Member

WalshyDev/blob-builds#15

README.md Outdated Show resolved Hide resolved
@ybw0014 ybw0014 requested a review from WalshyDev December 8, 2023 20:54
WalshyDev
WalshyDev previously approved these changes Dec 8, 2023
J3fftw1
J3fftw1 previously approved these changes Dec 8, 2023
Sfiguz7
Sfiguz7 previously approved these changes Dec 9, 2023
README.md Outdated Show resolved Hide resolved
@ybw0014 ybw0014 dismissed stale reviews from Sfiguz7, J3fftw1, and WalshyDev via 5fc40ca December 9, 2023 18:16
Co-authored-by: J3fftw <[email protected]>
@WalshyDev WalshyDev closed this Dec 11, 2023
@WalshyDev WalshyDev reopened this Dec 11, 2023
@ybw0014 ybw0014 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants