Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of check_description_files.py #2019

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Improve robustness of check_description_files.py #2019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6415c2f
CI: Accept repository name with at least "Slicer" or "slicer"
jcfr Mar 12, 2024
cb956d6
CI: Update check_git_repository_name hard-coding exceptions
jcfr Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 65 additions & 1 deletion scripts/check_description_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ def check_git_repository_name(extension_name, metadata):

repo_name = os.path.splitext(urlparse.urlsplit(metadata["scmurl"]).path.split("/")[-1])[0]

if not repo_name.startswith("Slicer"):
if repo_name in REPOSITORY_NAME_CHECK_EXCEPTIONS:
return

if "slicer" not in repo_name.lower():

variations = [prefix + repo_name for prefix in ["Slicer-", "Slicer_", "SlicerExtension-", "SlicerExtension_"]]

Expand Down Expand Up @@ -185,5 +188,66 @@ def main():
sys.exit(total_failure_count)


REPOSITORY_NAME_CHECK_EXCEPTIONS = [
"3DMetricTools",
"ai-assisted-annotation-client",
"aigt",
"AnglePlanes-Extension",
"AnomalousFiltersExtension",
"BoneTextureExtension",
"CarreraSlice",
"ChangeTrackerPy",
"CMFreg",
"CurveMaker",
"DatabaseInteractorExtension",
"dcmqi",
"DSC_Analysis",
"EasyClip-Extension",
"ErodeDilateLabel",
"FilmDosimetryAnalysis",
"GelDosimetryAnalysis",
"GyroGuide",
"iGyne",
"ImageMaker",
"IntensitySegmenter",
"MeshStatisticsExtension",
"MeshToLabelMap",
"ModelClip",
"MONAILabel",
"mpReview",
"NeedleFinder",
"opendose3d",
"OsteotomyPlanner",
"PBNRR",
"PedicleScrewSimulator",
"PercutaneousApproachAnalysis",
"PerkTutor",
"PET-IndiC",
"PETLiverUptakeMeasurement",
"PETTumorSegmentation",
"PickAndPaintExtension",
"PkModeling",
"PortPlacement",
"Q3DCExtension",
"QuantitativeReporting",
"ResectionPlanner",
"ScatteredTransform",
"Scoliosis",
"SegmentationAidedRegistration",
"SegmentationReview",
"SegmentRegistration",
"ShapePopulationViewer",
"ShapeRegressionExtension",
"ShapeVariationAnalyzer",
"SkullStripper",
"SNRMeasurement",
"SPHARM-PDM",
"T1Mapping",
"TCIABrowser",
"ukftractography",
"VASSTAlgorithms",
]


if __name__ == "__main__":
main()