Fixed item stack copy #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My-Name-Is-Jeff
approved these changes
May 19, 2024
Sychic
requested changes
May 19, 2024
src/main/kotlin/gg/skytils/skytilsmod/features/impl/mining/MiningFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/skytils/skytilsmod/mixins/hooks/inventory/SlotHook.kt
Show resolved
Hide resolved
Sychic
approved these changes
May 27, 2024
My-Name-Is-Jeff
pushed a commit
that referenced
this pull request
Jun 13, 2024
* fixed too many item copy calls * removed comment * inline item --------- Co-authored-by: hannibal2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed calling
ItemStack.copy()too often unnecessary.In
MiningFeatures.onDrawSlotwe are callingval item = event.slot.stack, even outside the HOTM inventories. This causes the injectedMixinSlotto callmarkTerminalItems. In here, we create a copy of the item stack before checking if the slot number is part ofSelectAllColorSolverorStartsWithSequenceSolver.