Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hide Non-Starred Mobs Nametags and Hide Terracota Nametags #4

Merged
merged 55 commits into from
Mar 14, 2021
Merged

Added Hide Non-Starred Mobs Nametags and Hide Terracota Nametags #4

merged 55 commits into from
Mar 14, 2021

Conversation

AzuredBlue
Copy link
Contributor

No description provided.

@@ -93,7 +93,10 @@ public void onSlotClick(GuiContainerEvent.SlotClickEvent event) {
event.setCanceled(true);
return;
}
if (!extraAttr.hasKey("baseStatBoostPercentage")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code won't run if protect starred items is not enabled, is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, was thinking if I should make it work with highlight, protect starred items or make a new feature, but i feel like its too minor for a new feature and doesnt make sense with highlight

if (Skytils.config.hideNonStarredNametags && event.entity instanceof EntityArmorStand && event.entity.hasCustomName()) {
String name = StringUtils.stripControlCodes(event.entity.getCustomNameTag());
if (!name.startsWith("✯ ") && name.contains("❤"))
if (name.contains("Lurker") || name.contains("Dreadlord") || name.contains("Souleater") || name.contains("Zombie") || name.contains("Skeleton") || name.contains("Skeletor") || name.contains("Sniper") || name.contains("Super Archer") || name.contains("Spider") || name.contains("Fels") || name.contains("Withermancer"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@My-Name-Is-Jeff My-Name-Is-Jeff requested review from Sychic and removed request for Sychic March 14, 2021 18:50
@My-Name-Is-Jeff My-Name-Is-Jeff merged commit bea8b2c into Skytils:main Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants