-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BPK-1754] Upgrade React Native to 0.57.3 #1114
Conversation
3b33672
to
4e4154b
Compare
native/.babelrc
Outdated
@@ -1,3 +1,3 @@ | |||
{ | |||
"presets": ["react-native"] | |||
"presets": ["module:metro-react-native-babel-preset"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2,52 +2,52 @@ PODS: | |||
- boost-for-react-native (1.63.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update is because I did pod update
to bump RN. I presume the other changes are ok though, seems to work fine.
native/package.json
Outdated
@@ -11,20 +11,21 @@ | |||
"android:build": "react-native run-android", | |||
"android": "npm run android:emulator & npm run android:build", | |||
"test": "jest --coverage", | |||
"storybook": "storybook start -p 7007 --root ../" | |||
"storybook": "storybook start -p 7007 --skip-packager | react-native start --watchFolders $PWD/.." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook used to run the RN packager for us but their usage doesn't work with the new RN (see storybookjs/storybook#4179).
So, now we run the packager ourselves. $PWD/..
is because Watchman won't accept a relative path (i.e. ..
), so this was my hack workaround.
native/package.json
Outdated
"react": "16.5.1", | ||
"react-dom": "16.5.1", | ||
"react-native": "0.57.1", | ||
"react-test-renderer": "16.5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Updated Storybook to match the version in the root
package.json
. We should keep these in sync. - Updated React as mandated in RN upgrade guide: https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#updating-to-this-version
@shaundon just by comparing our
In jest config, we have
|
4a48df0
to
1468bb5
Compare
Generated by 🚫 dangerJS |
769dcaa
to
3a2c989
Compare
3a2c989
to
a46919c
Compare
a46919c
to
9b05a5e
Compare
0f77f6e
to
bd7f9bf
Compare
bd7f9bf
to
e6f6bd7
Compare
e6f6bd7
to
aaf50af
Compare
aaf50af
to
e2448be
Compare
dd2b641
to
d348104
Compare
d348104
to
d07bf8f
Compare
Closing since we have moved the react-native code to https://github.com/Skyscanner/backpack-react-native |
Notes
We got Jest to run with the following things:
.babelrc
tobabel.config.js
(weird I know).@babel/core
andbabel-core
andbabel-jest
to deps, based on the RN upgrade guide.native
. This isn't desirable long term as it diverges from the version of Jest used in the root. However I think this is better for now to keep this PR small. After this I plan to do another PR to upgrade Jest for web, then I can remove Jest fromnative
.jest-cli
to deps to get rid ofenvironment.dispose is not a function
errors. How is this even a thing I really don't know