Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAN-3258: Update BpkHorizontalNav component #2167

Merged
merged 1 commit into from
Dec 18, 2024
Merged

PAN-3258: Update BpkHorizontalNav component #2167

merged 1 commit into from
Dec 18, 2024

Conversation

jacobhuang0121
Copy link
Contributor

@jacobhuang0121 jacobhuang0121 commented Dec 12, 2024 •
edited
Loading

https://skyscanner.atlassian.net/browse/PAN-3258

Remember to include the following changes:

  • Component README.md
  • Tests

If you are curious about how we review, please read through the code review guidelines

@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️ One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️

One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️

One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

Generated by 🚫 Danger Kotlin against 9664fd9

@jacobhuang0121 jacobhuang0121 added the skip-changelog Used for any changes that shouldn't be referrenced in the changelog label Dec 12, 2024
amburrrshand
amburrrshand approved these changes Dec 17, 2024
View reviewed changes
Copy link

@amburrrshand amburrrshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobhuang0121 jacobhuang0121 removed the request for review from bvitaliyg December 17, 2024 17:03
@frugoman frugoman merged commit 1eab3e8 into main Dec 18, 2024
6 of 7 checks passed
@frugoman frugoman deleted the panda/PAN-3258_Update_BpkHorizontalNav_component_to_limit_display_to_one_line branch December 18, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amburrrshand amburrrshand amburrrshand approved these changes

@frugoman frugoman frugoman approved these changes

Assignees
No one assigned
Labels
skip-changelog Used for any changes that shouldn't be referrenced in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobhuang0121 @frugoman @amburrrshand @JacobHuang0121-wq