[TEMPURA-2060] Contribute to Backpack library Badge icon with Painter #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-sobolev-skyscanner
added
minor
Generated by 🚫 Danger Kotlin against 2a6ebab |
marianeum
reviewed
Nov 28, 2024
|
|
||
| private val BadgeShape = RoundedCornerShape(BpkBorderRadius.Xs) | ||
|
|
||
| private fun Modifier.defaultIconSize(size: BpkIconSize): Modifier = |
There was a problem hiding this comment.
i don't think this is needed? badges should only ever have one icon size, so we don't need the BpkIconSize prop here - they're always small
There was a problem hiding this comment.
removed
| @@ -95,6 +97,14 @@ private fun BadgeRow( | |||
| else -> BpkIcon.TickCircle | |||
| }, | |||
| ) | |||
|
|
|||
| BpkBadge( | |||
There was a problem hiding this comment.
please regenerate the docs screenshots as well
There was a problem hiding this comment.
updated
| Row( | ||
| modifier = modifier | ||
| .semantics(mergeDescendants = true) { } | ||
| .border(1.dp, type.borderColor, BadgeShape) |
There was a problem hiding this comment.
not new, but while we're here: BpkBorderSize.Sm
There was a problem hiding this comment.
fixed
marianeum
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied functional from BpkButton to BpkBadge to add support for custom Badge icons. Compose only
Remember to include the following changes:
README.mdIf you are curious about how we review, please read through the code review guidelines