[NEUT-1872] Rename SponsoredBanner to InsetBanner #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellferreira
approved these changes
Oct 18, 2023
bvitaliyg
approved these changes
Oct 20, 2023
bvitaliyg
deleted the
neutron/NEUT-1872_rename_sponsoredbanner_to_insetbanner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NEUT-1872]
This component is not limited to sponsored experiences, thus renaming to
Insetis more appropiateTo check that no bugs have been introduced, the app has been rebuilt and is working correctly.
Additionally, I have searched throught the codebase for the
sponsoredstring (ignoring case), and this is the output:It's referenced at
strings.xml, as the Sponsored label is used for the story.No more references are found (apart from gradle history, and old internal references)
If you are curious about how we review, please read through the code review guidelines