-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bpkr 215 android graphic promo contribution #1721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Kotlin against 1c0abe4 |
ernestkamara
force-pushed
the
BPKR-215_Android_Graphic_promo_contribution
branch
from
September 19, 2023 12:23
52a6d4f
to
4486279
Compare
ernestkamara
force-pushed
the
BPKR-215_Android_Graphic_promo_contribution
branch
from
September 22, 2023 11:07
e333275
to
8c37f39
Compare
ernestkamara
force-pushed
the
BPKR-215_Android_Graphic_promo_contribution
branch
from
September 22, 2023 13:29
801dd49
to
d8e92b0
Compare
bvitaliyg
reviewed
Sep 27, 2023
...-compose/src/main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/BpkGraphicPromo.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Sep 27, 2023
...-compose/src/main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/BpkGraphicPromo.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Sep 27, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Sep 27, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Sep 27, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Sep 27, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Sep 27, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Sep 27, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Oct 20, 2023
...-compose/src/main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/BpkGraphicPromo.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Oct 20, 2023
...-compose/src/main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/BpkGraphicPromo.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Oct 20, 2023
...-compose/src/main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/BpkGraphicPromo.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Oct 20, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Oct 20, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Oct 20, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Show resolved
Hide resolved
bvitaliyg
reviewed
Nov 22, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
reviewed
Nov 22, 2023
...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt
Outdated
Show resolved
Hide resolved
bvitaliyg
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the BpkGraphicPromo component for Compose.
Animation:
gp_200ms.mp4
Remember to include the following changes:
README.md
If you are curious about how we review, please read through the code review guidelines