Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bpkr 215 android graphic promo contribution #1721

Merged
merged 35 commits into from
Nov 22, 2023

Conversation

ernestkamara
Copy link
Contributor

@ernestkamara ernestkamara commented Sep 11, 2023

Adding the BpkGraphicPromo component for Compose.

Screenshot 2023-09-22 at 14 41 32

screenshot-1695378022613

Animation:

gp_200ms.mp4

Remember to include the following changes:

  • Component README.md
  • Tests

If you are curious about how we review, please read through the code review guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Warnings
⚠️

One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated.

Generated by 🚫 Danger Kotlin against 1c0abe4

@ernestkamara ernestkamara force-pushed the BPKR-215_Android_Graphic_promo_contribution branch from 52a6d4f to 4486279 Compare September 19, 2023 12:23
@ernestkamara ernestkamara force-pushed the BPKR-215_Android_Graphic_promo_contribution branch from e333275 to 8c37f39 Compare September 22, 2023 11:07
@ernestkamara ernestkamara self-assigned this Sep 22, 2023
@ernestkamara ernestkamara added the minor A new & backwards compatible feature/component label Sep 22, 2023
@ernestkamara ernestkamara force-pushed the BPKR-215_Android_Graphic_promo_contribution branch from 801dd49 to d8e92b0 Compare September 22, 2023 13:29
@ernestkamara ernestkamara marked this pull request as ready for review September 22, 2023 13:45
@bvitaliyg bvitaliyg merged commit d7e9f8a into main Nov 22, 2023
8 checks passed
@bvitaliyg bvitaliyg deleted the BPKR-215_Android_Graphic_promo_contribution branch November 22, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor A new & backwards compatible feature/component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants