Allow title label font to be set

[ryanwaggoner]

No description provided.

[intonarumori]

Hey @ryanwaggoner , thanks for taking the time to contribute.

I'm afraid we cannot accept the PR in the current form.
If you look at the files changed tab it's evident that you have switched to space based tabbing.

It's impossible to see the real changes this way, basically the whole file is one block of change.

Would you mind fixing this issue?

Edit: sorry, the other way around, you are using tabs while the project uses spaces.

[ryanwaggoner]

Fixed

[intonarumori]

@ryanwaggoner Thanks.

One more thing, let's use titleFont in createTitleLabel like we do with titleColor.

[ryanwaggoner]

Ah yeah, I had that originally, and missed it when going back to spaces. One min.

[ryanwaggoner]

Done

[intonarumori]

@ryanwaggoner Thanks.

Do you think we could get rid of the change in the project file? It seems you just disabled tab based white spacing for that one file.
It would be nice to get that removed and really just have the changes in the SkyFloatingLabelTextField class.

[intonarumori]

@ryanwaggoner Great, many thanks.

I have to double check what happens if you change the titleFont to a smaller or larger one, and how the title label font height might affect the placement of other view components.

This might take a while so I will get back to you with my review and hopefully PR approval.

[intonarumori]

@ryanwaggoner
I've been looking at our test cases and just realised that you can set the title font already by using textField.titleLabel.font = yourCustomFont. Maybe that solves your current use cases and you can use it straight away.

I have to do some more investigations to determine if leaving titleLabel exposed or adding the titleFont property is a better choice in the long term. I get back to this PR with my findings.

[Fawxy]

It's nice having it as an @IBInspectable

[k0nserv]

Pelase put a space before { on this line.

[k0nserv]

Closing as #141 was merged