-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code style to common Swift style #125
Conversation
Omitted `self` where possible and update spacing after colons
This is great 👍 I've been thinking about swiftlint recently and this looks like a good step in that direction. Feel free to add it to this PR if you feel inclined, otherwise I'll do it on the back of your work. |
Also please credit yourself in |
Added swiftlint build phase and fixed errors and warnings generated by swiftlint
@k0nserv I used the default To fix the line length warnings (120 characters) I used this style of indentation.
I hope this is okay or is there a preferable style? Let me know when something is wrong or needs change. (There also was a commit I did not intend to push which I reverted afterwards) |
I think I prefer this style
@bogren opinions? |
Or like this? 😃
I think I prefer @k0nserv suggestion but put the next parameter below as well :)
|
This is how I would write it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks great :)
Thanks a bunch for the PR @moogle19 |
Hi,
I updated some of the variable declarations with spaces after the colons and also omitted
self
's where possible (as recommended).