Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block JGit from loading the system Git config #980

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

AzureAaron
Copy link
Collaborator

Values that JGit doesn't accept such as out of range ints causes the NEU repo loading to fail unless the user deletes their .gitconfig file, so we will just block JGit from loading the values in this file to avoid the issues.

@AzureAaron AzureAaron added the bug Something isn't working label Sep 1, 2024
@AzureAaron AzureAaron added this to the 1.22.2 milestone Sep 1, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Sep 1, 2024
@AzureAaron AzureAaron added the small change Small changes that are easier to review label Sep 1, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Sep 2, 2024
@AzureAaron AzureAaron merged commit 51b9b57 into SkyblockerMod:master Sep 2, 2024
1 check passed
@AzureAaron AzureAaron deleted the jgit-gitconfig-fix branch September 2, 2024 08:13
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Sep 2, 2024
Fluboxer pushed a commit to Fluboxer/Skyblocker that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small change Small changes that are easier to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants