Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixins Review #936

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Mixins Review #936

merged 1 commit into from
Aug 17, 2024

Conversation

AzureAaron
Copy link
Collaborator

  • Fixes the DyeColorComponentMixin wiping out the target's hashCode, toString, and equals implementation due to the mixin class being a record
  • Rewrote some mixins to be more precise/efficient
  • Fixed some formatting issues
  • Fixed the CallbackInfo param being named inconsistently

@AzureAaron AzureAaron added the bug Something isn't working label Aug 17, 2024
@AzureAaron AzureAaron added this to the 1.22 milestone Aug 17, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Aug 17, 2024
@AzureAaron AzureAaron added the small change Small changes that are easier to review label Aug 17, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 17, 2024
@AzureAaron AzureAaron merged commit e0f8595 into SkyblockerMod:master Aug 17, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 17, 2024
@AzureAaron AzureAaron deleted the mixins-review branch August 17, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working small change Small changes that are easier to review
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@AzureAaron @viciscat @LifeIsAParadox