Mark all secrets missing in subcommand #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would put this under Also, maybe we should add suggestions to the secret index. |
|
done |
kevinthegreat1
previously approved these changes
Aug 16, 2024
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonManager.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
merge me please
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Aug 18, 2024
LifeIsAParadox
added
merge me please
|
This is pretty overdue, so we can include this in 1.22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a subcommand for marking every secret in the current dungeons room as missing.