Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always load NEU repo #920

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Always load NEU repo #920

merged 1 commit into from
Aug 16, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

No description provided.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Aug 13, 2024
@kevinthegreat1 kevinthegreat1 mentioned this pull request Aug 13, 2024
Closed
@kevinthegreat1 kevinthegreat1 added bug Something isn't working small change Small changes that are easier to review labels Aug 13, 2024
@viciscat
Copy link
Collaborator

viciscat commented Aug 13, 2024 •
edited
Loading

fixes #919
doesn't workNOOOOOOOOOOOOOOOOOo

@viciscat viciscat linked an issue Aug 13, 2024 that may be closed by this pull request
IllegalStateException - days of NULL #919
Closed
@AzureAaron AzureAaron added this to the 1.22 milestone Aug 14, 2024
@kevinthegreat1
Copy link
Collaborator Author

fixes #919 doesn't workNOOOOOOOOOOOOOOOOOo

Wdym? It seems to be working fine.

AzureAaron
AzureAaron approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but it doesn't look like anything would be broken because of this

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 16, 2024
@AzureAaron AzureAaron merged commit d8381fd into SkyblockerMod:master Aug 16, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 16, 2024
kevinthegreat1 added a commit that referenced this pull request Aug 20, 2024
@kevinthegreat1
Always load NEU repo (#920)
f8b91f9 
(cherry picked from commit d8381fd)
@kevinthegreat1 kevinthegreat1 deleted the neu-repo branch August 20, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working small change Small changes that are easier to review
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

IllegalStateException - days of NULL
4 participants
@kevinthegreat1 @viciscat @AzureAaron @LifeIsAParadox