Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SuperpairsSolver not starting properly #918

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Fix SuperpairsSolver not starting properly #918

merged 5 commits into from
Aug 14, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Aug 13, 2024

Also cleans up a lot of experiments stuff that was forgotten during the great container matcher refactor

@LifeIsAParadox LifeIsAParadox added the wip This PR is a work in progress label Aug 13, 2024
@AzureAaron AzureAaron added this to the 1.22 milestone Aug 13, 2024
@AzureAaron AzureAaron linked an issue Aug 13, 2024 that may be closed by this pull request
superpairs solver broken #887
Closed
@Emirlol Emirlol marked this pull request as ready for review August 13, 2024 08:21
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels Aug 13, 2024
@Emirlol Emirlol added bug Something isn't working wip This PR is a work in progress tester needed This is used for a Discord webhook to create a thread and notify the tester. and removed reviews needed This PR needs reviews labels Aug 13, 2024
AzureAaron
AzureAaron previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solver works for me now so it looks good

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed wip This PR is a work in progress labels Aug 13, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Aug 13, 2024
kevinthegreat1
kevinthegreat1 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some Javadocs.

src/main/java/de/hysky/skyblocker/skyblock/experiment/SuperpairsSolver.java Show resolved Hide resolved
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 13, 2024
@AzureAaron AzureAaron merged commit 931898c into SkyblockerMod:master Aug 14, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 14, 2024
@Emirlol Emirlol deleted the experiments-fix branch August 18, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

@AzureAaron AzureAaron AzureAaron left review comments

Assignees
No one assigned
Labels
bug Something isn't working tester needed This is used for a Discord webhook to create a thread and notify the tester.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

superpairs solver broken
4 participants
@Emirlol @AzureAaron @kevinthegreat1 @LifeIsAParadox