Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat rules thingamabobs #897

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Chat rules thingamabobs #897

merged 2 commits into from
Aug 15, 2024

Conversation

viciscat
Copy link
Collaborator

@viciscat viciscat commented Aug 7, 2024

  • Changed Show Announcement so it uses Title Container for consistency
  • Unused imports cleanup

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Aug 7, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh what could possibly go wrong.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 8, 2024
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed merge me please Pull requests that are ready to merge labels Aug 9, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed changes requested This PR need changes labels Aug 11, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Aug 15, 2024
AzureAaron
AzureAaron approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 15, 2024
@AzureAaron AzureAaron merged commit 9fc0b3c into SkyblockerMod:master Aug 15, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 15, 2024
@AzureAaron AzureAaron mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiden-powers aiden-powers aiden-powers approved these changes

@AzureAaron AzureAaron AzureAaron approved these changes

@kevinthegreat1 kevinthegreat1 kevinthegreat1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@viciscat @AzureAaron @aiden-powers @kevinthegreat1 @LifeIsAParadox