-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slayer Helpers] Slayer Highlights, Blaze Helpers and Glow Caching #888
[Slayer Helpers] Slayer Highlights, Blaze Helpers and Glow Caching #888
Conversation
471da6f
to
a087b15
Compare
src/main/java/de/hysky/skyblocker/config/categories/SlayersCategory.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/crimson/slayer/AttunementColours.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/crimson/slayer/FirePillarAnnouncer.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/crimson/slayer/FirePillarAnnouncer.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerEntitiesGlow.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerEntitiesGlow.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerEntitiesGlow.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw should be the last review. I have also referenced Aaron's previous review.
src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerEntitiesGlow.java
Outdated
Show resolved
Hide resolved
84eff2b
to
68ee675
Compare
269bd6c
to
afd61e0
Compare
src/main/java/de/hysky/skyblocker/config/categories/SlayersCategory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, in future we will need to optimize the glow/box calculations to not constantly run when an entity is rendered.
I'm sure there's a fair bit more optimisation that can be done, but I noticed that i go from ~0.7% doing these calcs while idling on my island -> 0.25% with these changes which was more than enough for me to be happy with lol |
I was talking about iterating the scoreboard to check if we're in a slayer or not. My idea is roughly to create an event for when the mod updates the scoreboard, check the updated scoreboard value and set a static boolean that can be read from. I wasn't talking about anything beyond that though |
ahh, well technically that's getting cached too so it's not every frame render, but ur suggestion definitely a far better implementation than the current mechanism |
Remade this PR cause The merge conflicts were horrible
This PR Also reworks "ShouldGlow" Detection