Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profile Viewer] Use Taming Levels Added to API. Maybe fix wardrobe + inv. #880

Merged
merged 2 commits into from
Aug 3, 2024
Merged

[Profile Viewer] Use Taming Levels Added to API. Maybe fix wardrobe + inv. #880

merged 2 commits into from
Aug 3, 2024

Conversation

BigloBot
Copy link
Contributor

Potential fix for active armour inserted into wrong wardrobe slot

@BigloBot
Use Taming Levels Added to API.
a2a77a0 
Potential fix for active armour inserted into wrong wardrobe slot
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 30, 2024
@kevinthegreat1 kevinthegreat1 added this to the 1.22 milestone Jul 31, 2024
@kevinthegreat1 kevinthegreat1 added bug Something isn't working small change Small changes that are easier to review labels Jul 31, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. You can fix the formatting if you want.

...sky/skyblocker/skyblock/profileviewer/inventory/itemLoaders/WardrobeInventoryItemLoader.java Outdated Show resolved Hide resolved
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 31, 2024
@BigloBot @kevinthegreat1
Update src/main/java/de/hysky/skyblocker/skyblock/profileviewer/inven…
442f786 
…tory/itemLoaders/WardrobeInventoryItemLoader.java

Co-authored-by: Kevin <[email protected]>
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Jul 31, 2024
kevinthegreat1
kevinthegreat1 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. But you'll have to fight it out with #874.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 2, 2024
viciscat
viciscat approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume biglo tested this

@AzureAaron AzureAaron merged commit 9b4ca8c into SkyblockerMod:master Aug 3, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 3, 2024
@BigloBot BigloBot deleted the pv-fixes branch August 3, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

@viciscat viciscat viciscat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working small change Small changes that are easier to review
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@BigloBot @viciscat @kevinthegreat1 @LifeIsAParadox @AzureAaron