[WORKING DRAFT] Better dungeon door detection/overlay #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just did a dozen runs with this, and I haven't really found any issues, doors are rendering where they're expected to |
kevinthegreat1
requested changes
Aug 6, 2024
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonMapUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonMapUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/Room.java
Outdated
Show resolved
Hide resolved
Comment on lines
+398
to
+399
| } | ||
| else if (matchingRoomsSize == 1) { |
There was a problem hiding this comment.
Suggested change
| } | |
| else if (matchingRoomsSize == 1) { | |
| } else if (matchingRoomsSize == 1) { |
There was a problem hiding this comment.
My bad on those, I didn't correctly apply the formatting config listed on the wiki.
While the other changes all apply just like you did, it seems like the formatter really doesn't want to have the else if on the same line as the closing bracket.
Is it a config I'm missing ? If I apply this, the next person to work on that file might just revert it.
There was a problem hiding this comment.
I’m not sure. The intellij default keeps them on the same line.
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonMapUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/secrets/DungeonManager.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
Also threw in an extra comment regarding map colors, and fixed `doorPos` being `doorpos`.
|
I believe this should be it, minus the small nitpick about |
kevinthegreat1
approved these changes
Aug 8, 2024
LifeIsAParadox
added
merge me please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just spent the day rewriting the code that detects dungeons doors.
Let me know if I'm doing anything wrong / there are any concerns regarding the proposed code.
Summary of changes compared to current implementation
BetterMapdoes on 1.8)Concerns
Code quality ?
Hardcoded values for map colors, as well as position code that might not be easily understood
Currently, the doors are checked for every tick, which might not be a good thing for performance. It could be possible to only check when necessary :
Feel free to test those changes, things have been working pretty smoothly on my end, and I haven't been able to find any bugs / wrong placements for the doors.