Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Notifications #877

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Update Notifications #877

merged 3 commits into from
Aug 18, 2024

Conversation

AzureAaron
Copy link
Collaborator

This should™ work

@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jul 29, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 29, 2024
@AzureAaron AzureAaron added this to the 1.22 milestone Jul 30, 2024
viciscat
viciscat reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am i big dumb or it doesnt check github for new alphas and betas

@AzureAaron
Copy link
Collaborator Author

am i big dumb or it doesnt check github for new alphas and betas

Only Modrinth matters here since we don't post such experimental releases on GH anyways, and GitHub's api does not contain the necessary metadata to allow for version matching.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 17, 2024
@AzureAaron AzureAaron merged commit 996ff07 into SkyblockerMod:master Aug 18, 2024
1 check passed
@AzureAaron AzureAaron deleted the update-notification branch August 18, 2024 05:05
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat approved these changes

@LifeIsAParadox LifeIsAParadox LifeIsAParadox approved these changes

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@AzureAaron @LifeIsAParadox @viciscat