-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuudra Part 2 #873
Kuudra Part 2 #873
Conversation
There are also few popular features on 1.8 mods regarding announcing fresh tools, highlighting teammates with it (parse chat) and showing where to go next for optimal building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but why do we have 2 methods for MobGlow (shouldGlow and glowColor)? Can't we just make glowColor return an OptionalInt? Sometimes both methods call the same method
src/main/java/de/hysky/skyblocker/skyblock/crimson/kuudra/KuudraGlow.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/crimson/kuudra/DangerWarning.java
Outdated
Show resolved
Hide resolved
bac568b
to
54ab18e
Compare
54ab18e
to
87fcbf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for reformatting KuudraWaypoints
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my unrelated remark got ignored D:
We could perhaps change it to work like this but after the slayer entity glow and maybe my carnival stuff happens since those also touch that part of the code |
I've added a kuudra glow and a danger warning, I plan to make more but it will take longer so I'd rather people be able to enjoy these new features for the release.