Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuudra Part 2 #873

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Kuudra Part 2 #873

merged 4 commits into from
Aug 3, 2024

Conversation

AzureAaron
Copy link
Collaborator

I've added a kuudra glow and a danger warning, I plan to make more but it will take longer so I'd rather people be able to enjoy these new features for the release.

@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jul 29, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 29, 2024
@Fluboxer
Copy link
Contributor

There are also few popular features on 1.8 mods regarding announcing fresh tools, highlighting teammates with it (parse chat) and showing where to go next for optimal building

@AzureAaron AzureAaron added this to the 1.22 milestone Jul 30, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but why do we have 2 methods for MobGlow (shouldGlow and glowColor)? Can't we just make glowColor return an OptionalInt? Sometimes both methods call the same method

Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for reformatting KuudraWaypoints.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 2, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my unrelated remark got ignored D:

@AzureAaron
Copy link
Collaborator Author

my unrelated remark got ignored D:

We could perhaps change it to work like this but after the slayer entity glow and maybe my carnival stuff happens since those also touch that part of the code

@AzureAaron AzureAaron merged commit c160dac into SkyblockerMod:master Aug 3, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 3, 2024
@AzureAaron AzureAaron deleted the kuudra-part-2 branch August 5, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants