Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skyblock XP Messages #872

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Skyblock XP Messages #872

merged 3 commits into from
Aug 4, 2024

Conversation

AzureAaron
Copy link
Collaborator

When you get Skyblock XP the message in the action bar is also put into the chat, pretty useful since the action bar text goes away quickly and people might not see it.

image

@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jul 29, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 29, 2024
@AzureAaron AzureAaron added this to the 1.22 milestone Jul 30, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 31, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Aug 2, 2024
kevinthegreat1
kevinthegreat1 requested changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hashing part is very close to chat stacking, we should probably just implement chat stacking at some point in the future and we won't need this anymore.

src/main/java/de/hysky/skyblocker/config/configs/ChatConfig.java Outdated Show resolved Hide resolved
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Aug 2, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Aug 2, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 3, 2024
@kevinthegreat1 kevinthegreat1 merged commit da041ea into SkyblockerMod:master Aug 4, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 4, 2024
@AzureAaron AzureAaron deleted the level-xp-message branch August 5, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

@viciscat viciscat viciscat left review comments

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@AzureAaron @viciscat @kevinthegreat1 @LifeIsAParadox