Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up id mess and add tests #867

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Clean up id mess and add tests #867

merged 5 commits into from
Jul 31, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 commented Jul 27, 2024 •
edited
Loading

Move skyblock api id and neu id methods to ItemUtils.
Fix neu id for enchanted books.
Fix a bunch of misuses for the different types of ids.

Add tests for the three types of ids to ItemUtilsTest.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 27, 2024
@kevinthegreat1 kevinthegreat1 marked this pull request as draft July 27, 2024 08:25
@LifeIsAParadox LifeIsAParadox added wip This PR is a work in progress and removed reviews needed This PR needs reviews labels Jul 27, 2024
@kevinthegreat1 kevinthegreat1 marked this pull request as ready for review July 28, 2024 08:50
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels Jul 28, 2024
@kevinthegreat1 kevinthegreat1 added bug Something isn't working high priority This issue or PR is prioritized, likely due to a significant loss of a function. backport me labels Jul 28, 2024
@kevinthegreat1 kevinthegreat1 added this to the 1.22 milestone Jul 29, 2024
@kevinthegreat1 kevinthegreat1 mentioned this pull request Jul 29, 2024
Merged
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jul 30, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Jul 30, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 30, 2024
@kevinthegreat1 kevinthegreat1 merged commit 4326f83 into SkyblockerMod:master Jul 31, 2024
1 check passed
@kevinthegreat1 kevinthegreat1 deleted the id-cleanup branch July 31, 2024 06:07
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jul 31, 2024
kevinthegreat1 added a commit that referenced this pull request Aug 10, 2024
@kevinthegreat1
Merge pull request #867 from kevinthegreat1/id-cleanup
c40b6f9 
Clean up id mess and add tests

(cherry picked from commit 4326f83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working high priority This issue or PR is prioritized, likely due to a significant loss of a function.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinthegreat1 @AzureAaron @LifeIsAParadox