Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick nav tooltip #865

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Quick nav tooltip #865

merged 4 commits into from
Aug 4, 2024

Conversation

viciscat
Copy link
Collaborator

@viciscat viciscat commented Jul 25, 2024 •
edited
Loading

wow what a feature
https://github.com/user-attachments/assets/6a423e7d-b7a8-4030-963c-9f5b1ae0a58d
why does it not embed fuck you github

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 25, 2024
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jul 25, 2024
kevinthegreat1
kevinthegreat1 requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a review package for you, along with some merge conflicts. :)

src/main/java/de/hysky/skyblocker/config/configs/QuickNavigationConfig.java Outdated Show resolved Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/quicknav/QuickNavButton.java Outdated Show resolved Hide resolved
src/main/resources/assets/skyblocker/lang/en_us.json Outdated Show resolved Hide resolved
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Jul 26, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Jul 26, 2024
@AzureAaron AzureAaron added this to the 1.22 milestone Jul 30, 2024
@kevinthegreat1 kevinthegreat1 added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jul 30, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Jul 30, 2024
@viciscat
empty string
aaf2792 
get it? cuz the commit is to add info that you can put an empty string to hide the tooltip HAHAHAHA
@kevinthegreat1 kevinthegreat1 added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Aug 2, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Aug 2, 2024
@viciscat @kevinthegreat1
rip logs
95063d2 
Co-authored-by: Kevin <[email protected]>
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 3, 2024
@kevinthegreat1 kevinthegreat1 merged commit 2dd2ddf into SkyblockerMod:master Aug 4, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron left review comments

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@viciscat @AzureAaron @kevinthegreat1 @LifeIsAParadox