Treasure Chest Highlighter for crystal hollows #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
added
the
merge conflicts
|
This has some merge conflicts and needs rebasing lol |
olim88
force-pushed
the
treasure-chest-highlighter
branch
from
b838ca0
to
704bfc3
Compare
LifeIsAParadox
removed
the
merge conflicts
lol i did not expect that much to have change as the branch is only like a week old |
AzureAaron
previously requested changes
Jul 16, 2024
src/main/java/de/hysky/skyblocker/skyblock/dwarven/CrystalsChestHighlighter.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
viciscat
reviewed
Jul 31, 2024
LifeIsAParadox
added
merge conflicts
4 tasks
olim88
force-pushed
the
treasure-chest-highlighter
branch
from
9934306
to
d449ccc
Compare
LifeIsAParadox
added
reviews needed
oops
the chest it self was getting in the way of rendering the outline of the chest. so make bounding box slightly bigger
kevinthegreat1
approved these changes
Aug 3, 2024
LifeIsAParadox
added
merge me please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highlights treasure chests while powder grinding.
wohlhabend suggested that I complete this feature also suggested in discord (https://discord.com/channels/879732108745125969/1256712247858692247)
i have tested this with max "Great explore" and level 0. (not in-between but should work fine)