Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare npe in OrderTerminal #848

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix rare npe in OrderTerminal #848

merged 1 commit into from
Jul 22, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

Fix #847

@kevinthegreat1 kevinthegreat1 added bug Something isn't working crash This is a crash small change Small changes that are easier to review labels Jul 15, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 15, 2024
@kevinthegreat1 kevinthegreat1 mentioned this pull request Jul 15, 2024
Closed
@x-yingcan-x
Copy link
Contributor

just had another crash, hope this merged to bleeding edge, not rlly want to test this at cost of lose those features

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 20, 2024
@AzureAaron AzureAaron merged commit 743f707 into SkyblockerMod:master Jul 22, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jul 22, 2024
@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge backport me and removed merge me please Pull requests that are ready to merge labels Jul 22, 2024
@kevinthegreat1 kevinthegreat1 deleted the order-terminal-npe branch July 26, 2024 07:26
kevinthegreat1 added a commit that referenced this pull request Jul 26, 2024
@kevinthegreat1
Fix rare npe in OrderTerminal (#848)
6d7db4b 
(cherry picked from commit 743f707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working crash This is a crash small change Small changes that are easier to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rare NullPointerException in order term solver
5 participants
@kevinthegreat1 @x-yingcan-x @viciscat @LifeIsAParadox @AzureAaron