-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raytracing to the egg finder to make it fairer #845
Add raytracing to the egg finder to make it fairer #845
Conversation
- Added skyblock hour - Added events for each time unit (year, season, month, day, hour) that are fired when the time unit changes value - Removed magic numbers and added constant fields holding the numbers
Could the raycast be an option? Like a setting called “enable egg waypoints without seeing them (possibly bannable use at your own risk)” or something like that |
no, it's not, ESP is a cheat and it's an accident that we included such behavior |
Exactly this. I just never had the thought of whether it was cheaty or not when making it. Took a while to fix due to some skill issues and laziness. This PR is how it should've been since the start. I know it's currently a bit hard to use, as all it does is tell you if you unobstructed vision to eggs. I was also planning on adding labels for possible locations and egg locator helper for that, but I have other stuff to do for now so those will come separately later on. |
src/main/java/de/hysky/skyblocker/skyblock/chocolatefactory/EggFinder.java
Show resolved
Hide resolved
Add raytracing to the egg finder to make it fairer (cherry picked from commit 023bf78)
I'm honestly not sure how to explain the changes. Might be better to read commits.
Fixes #832 by adding ray tracing every tick. Also has better logic for waypoints and chat messages, now it doesn't highlight eggs/send messages when the egg was already found in another island, and this state is reset when the egg's reset hour happens, which is at 7, 14, 21 (7am, 2pm, 9 pm)
Also cleans up and improves
SkyblockTime
. Now it includes hour and refreshes every 50 secs (a skyblock hour). There are also events for when the time unit changes value.