Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result text displaying weirdly when its too long in the recipe book #842

Merged

Conversation

AzureAaron
Copy link
Collaborator

As a side effect of migrating away from legacy formatting for the NEU repo items, when an item's name was too long in the recipe book it would get trimmed but the resulting text lost its formatting and was prefixed with null.

@AzureAaron AzureAaron added the bug Something isn't working label Jul 14, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 14, 2024
@AzureAaron AzureAaron added the small change Small changes that are easier to review label Jul 14, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 14, 2024
@kevinthegreat1 kevinthegreat1 merged commit 9244fb6 into SkyblockerMod:master Jul 14, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jul 14, 2024
kevinthegreat1 pushed a commit that referenced this pull request Jul 14, 2024
@AzureAaron AzureAaron deleted the null-recipe-book-name-fix branch July 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small change Small changes that are easier to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants