Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PetLevelAdder working incorrectly in the sea creatures guide #817

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Jul 2, 2024

Now it checks the custom data nbt for an id key that equals PET to be certain that the item is indeed, a pet.

I've also added a javadoc for the ItemUtils#getCustomData method because why not.

Images

image
image

@viciscat viciscat added the small change Small changes that are easier to review label Jul 3, 2024
viciscat
viciscat previously approved these changes Jul 3, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like it will explode or anything

@Emirlol Emirlol added bug Something isn't working reviews needed This PR needs reviews labels Jul 4, 2024
@kevinthegreat1 kevinthegreat1 added the bleeding edge This PR has been accepted into bleeding edge label Jul 5, 2024
@AzureAaron AzureAaron added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 8, 2024
@kevinthegreat1 kevinthegreat1 merged commit 288151a into SkyblockerMod:master Jul 8, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jul 8, 2024
@Emirlol Emirlol deleted the fix-pet-slot-text branch July 8, 2024 13:52
kevinthegreat1 added a commit that referenced this pull request Jul 10, 2024
Fix PetLevelAdder working incorrectly in the sea creatures guide

(cherry picked from commit 288151a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bleeding edge This PR has been accepted into bleeding edge bug Something isn't working small change Small changes that are easier to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants