Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply npc price tooltip by the amount of items in the sack #782

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Jun 17, 2024

I stole the code from the bz price tooltip (that already works) and a quick test gave me positive results.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jun 17, 2024
@Emirlol
Copy link
Collaborator Author

Emirlol commented Jun 17, 2024

Example:
image
Don't mind the skyblock id, that's from firmament and I find it kinda useful

@Emirlol Emirlol force-pushed the npc-price-sack-amount-multiplication branch from c2bc0e9 to c35129a Compare June 19, 2024 08:26
@AzureAaron AzureAaron added the bug Something isn't working label Jun 20, 2024
@kevinthegreat1 kevinthegreat1 added small change Small changes that are easier to review bleeding edge This PR has been accepted into bleeding edge labels Jun 23, 2024
@BigloBot
Copy link
Contributor

BigloBot commented Jun 26, 2024

image
seems to indeed work :3

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 6, 2024
@kevinthegreat1 kevinthegreat1 merged commit 7b02937 into SkyblockerMod:master Jul 8, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jul 8, 2024
@Emirlol Emirlol deleted the npc-price-sack-amount-multiplication branch July 8, 2024 13:52
kevinthegreat1 pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bleeding edge This PR has been accepted into bleeding edge bug Something isn't working small change Small changes that are easier to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants