Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Craft Cost Tooltip #781

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

BigloBot
Copy link
Contributor

@BigloBot BigloBot commented Jun 17, 2024

Off by default, cause don't want to noisy up tooltips on default config

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jun 17, 2024
@Emirlol
Copy link
Collaborator

Emirlol commented Jun 17, 2024

This is really good, I've been looking for such a thing for a long time. There are a few things that I want to suggest, though:

  • Recursively checking the cost of the whole recipe tree with a depth limit in the config, defaulting to 1 to only show the cost of the initial recipe.
  • A config setting to choose between sell price and buy price, or maybe even display both as some things cost a lot to insta-buy, so there's the option of buy orders if you want to get it cheaper.

@BigloBot BigloBot force-pushed the Craft-Cost-Tooltip branch 3 times, most recently from caf1969 to 91408b3 Compare June 17, 2024 21:27
@BigloBot
Copy link
Contributor Author

This is really good, I've been looking for such a thing for a long time. There are a few things that I want to suggest, though:

* Recursively checking the cost of the whole recipe tree with a depth limit in the config, defaulting to 1 to only show the cost of the initial recipe.

* A config setting to choose between sell price and buy price, or maybe even display both as some things cost a lot to insta-buy, so there's the option of buy orders if you want to get it cheaper.

Added recursive cost calculation
Adding 3 config settings for 1 line in a tooltip kinda seems a lil' excessive though

@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jun 19, 2024
@kevinthegreat1 kevinthegreat1 added the bleeding edge This PR has been accepted into bleeding edge label Jun 24, 2024
@BigloBot BigloBot requested review from viciscat and Emirlol July 5, 2024 23:23
@viciscat
Copy link
Collaborator

viciscat commented Jul 5, 2024

no

@BigloBot
Copy link
Contributor Author

BigloBot commented Jul 5, 2024

no

care to elaborate :(

@viciscat
Copy link
Collaborator

viciscat commented Jul 5, 2024

i will tomorrow, first i eep

@kevinthegreat1
Copy link
Collaborator

Vic let me know if you want me to look at this too.

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jul 7, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i think

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed changes requested This PR need changes labels Jul 7, 2024
@Fluboxer
Copy link
Contributor

Fluboxer commented Jul 7, 2024

remind me, in current state is it smart enough to NOT count crafting 8 of something as crafting 1?

@kevinthegreat1 kevinthegreat1 merged commit f9c8129 into SkyblockerMod:master Jul 8, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bleeding edge This PR has been accepted into bleeding edge new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants