-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Craft Cost Tooltip #781
Add Craft Cost Tooltip #781
Conversation
This is really good, I've been looking for such a thing for a long time. There are a few things that I want to suggest, though:
|
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/CraftPriceTooltip.java
Outdated
Show resolved
Hide resolved
caf1969
to
91408b3
Compare
Added recursive cost calculation |
…ipes that arent recipes from blowing up the game
91408b3
to
77fbbf6
Compare
cae7e16
to
8f11e44
Compare
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/CraftPriceTooltip.java
Outdated
Show resolved
Hide resolved
no |
care to elaborate :( |
i will tomorrow, first i eep |
Vic let me know if you want me to look at this too. |
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/CraftPriceTooltip.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/CraftPriceTooltip.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/categories/GeneralCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/CraftPriceTooltip.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/CraftPriceTooltip.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, i think
remind me, in current state is it smart enough to NOT count crafting 8 of something as crafting 1? |
Off by default, cause don't want to noisy up tooltips on default config