-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule mayor cache ticking to the next year rather than every 20 mins #751
Schedule mayor cache ticking to the next year rather than every 20 mins #751
Conversation
remind me, how do we currently handle jerry perks and won't it deepfry it? |
We don't. |
You can do |
Is there a need to, though? |
9684b31
to
12cfb6c
Compare
I would appreciate it, this is causing a lot of merge conflicts and is difficult to review. |
12cfb6c
to
411a62d
Compare
Utils should be converted back into spaces. We really can't afford the merge conflicts rn. |
Also adds more robust handling of get request failures
411a62d
to
3d75f5b
Compare
This should reduce the API calls for the mayor endpoint by quite a lot, as a year lasts 5 days and 4 hours and ticking once per year compared to every 20 mins is a big difference.
This PR also fixes the
SkyblockTime
update scheduling. It was multiplied by 24 instead of 20 as a typo, so it was updating late by 4 minutes each passing day.One thing I'm not sure about is whether the API updates the current mayor instantly. This is most likely false, but then idk how much extra time should be waited before the API call.