-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search overlay #739
Improve search overlay #739
Conversation
adds the ability to search for max level pet as well as hiding skins when search for a pet. and when i item is starable adds the ability to search for an amount of stars
when searching the ah make pets show ahead of skins ect when they are a likly match
I've been waiting to see this added, great pr imo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great pr!
Even though it took a little bit of thinking to use the stars and pets feature. (I had to click the search suggestion.) Also, it seems like searching with stars easily exceeds the character count, and I don't seem to get what I searched for?
* @param context context | ||
* @param mouseX mouseX | ||
* @param mouseY mouseY | ||
* @param delta delta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W Javadoc xd
src/main/java/de/hysky/skyblocker/skyblock/searchoverlay/OverlayScreen.java
Show resolved
Hide resolved
oh, you can just hover and click? Well then forget what I said, I thought it is one of those silly designs where you need to click 10 times to get 10 stars selected |
This alignment is correct, as olim pointed out.
No, you click the star you want. So I don’t think we need or can have your suggestions. |
I just looked at the code and texture again. The social interactions background has one pixel of black border on the top and left but it has one pixel of white border on the bottom and right. So yes, it looks one pixel off, but I think it's fine as it. |
improve look of search overlay and added pet and star options.
added background
added max pet level and otherwise add
]
to only get pets when searching for themadded dungeon stars
prioritise pets in auction house to show above skins