Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search overlay #739

Merged
merged 8 commits into from
Jun 2, 2024

Conversation

olim88
Copy link
Contributor

@olim88 olim88 commented May 29, 2024

improve look of search overlay and added pet and star options.

added background

image
image

added max pet level and otherwise add ] to only get pets when searching for them

image
image

added dungeon stars

image
image

prioritise pets in auction house to show above skins

image

adds the ability to search for max level pet as well as hiding skins when search for a pet. and when i item is starable adds the ability to search for an amount of stars
when searching the ah make pets show ahead of skins ect when they are a likly match
add background an move stars and pet options to look better hopefully
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label May 29, 2024
@UpFault
Copy link
Contributor

UpFault commented May 29, 2024

I've been waiting to see this added, great pr imo

Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pr!

Even though it took a little bit of thinking to use the stars and pets feature. (I had to click the search suggestion.) Also, it seems like searching with stars easily exceeds the character count, and I don't seem to get what I searched for?

Comment on lines +185 to +188
* @param context context
* @param mouseX mouseX
* @param mouseY mouseY
* @param delta delta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W Javadoc xd

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels May 31, 2024
@BigloBot
Copy link
Contributor

image
yells in allignment noises

@Fluboxer
Copy link
Contributor

while I didn't test it, I do have a suggestions:

  1. Max out normal (and in 2nd action - master) stars if you hold shift
  2. Master stars should be shown as circle number, like they do ingame; use freed space to count stars
    изображение

@olim88
Copy link
Contributor Author

olim88 commented May 31, 2024

I had to click the search suggestion

it applies when the whole name of an item is what is search for (if you type the whole name it will still work).

searching with stars easily exceeds the character count, and I don't seem to get what I searched for

Yes when searching in the auction house the sign only has space for 30 characters. however the command (/ahsearch) gets around that and could be used instead however this would not work without cookie so i do not know another way to get past the limit

yells in allignment noises

this is just because buttons have extra space for the highlight to go
image

Max out normal (and in 2nd action - master) stars if you hold shift

I do not fully understand this suggestion. hold shift while pressing enter? hold shift when clicking on the button? hold shift when selecting a dungeon item? just holding shift while in the menu?

Master stars should be shown as circle number, like they do ingame;

It is converted to that format when its outputted. How would you be able to to input how many master stars you would like, when there is not a line of stars to click on, when using this method?

@Fluboxer
Copy link
Contributor

I do not fully understand this suggestion. hold shift while pressing enter? hold shift when clicking on the button? hold shift when selecting a dungeon item? just holding shift while in the menu?

It is converted to that format when its outputted. How would you be able to to input how many master stars you would like, when there is not a line of stars to click on, when using this method?

oh, you can just hover and click? Well then forget what I said, I thought it is one of those silly designs where you need to click 10 times to get 10 stars selected

@kevinthegreat1
Copy link
Collaborator

image yells in allignment noises

This alignment is correct, as olim pointed out.

oh, you can just hover and click? Well then forget what I said, I thought it is one of those silly designs where you need to click 10 times to get 10 stars selected

No, you click the star you want. So I don’t think we need or can have your suggestions.

@BigloBot
Copy link
Contributor

BigloBot commented Jun 1, 2024

image yells in allignment noises

This alignment is correct, as olim pointed out.

oh, you can just hover and click? Well then forget what I said, I thought it is one of those silly designs where you need to click 10 times to get 10 stars selected

No, you click the star you want. So I don’t think we need or can have your suggestions.

image
compared to the other side it looks off by 1. I believe its "technically" alligned because it has a black pixel here but it visually still looks off imo.

Zoom ins to highlight the problem:
image
vs.
image

@kevinthegreat1
Copy link
Collaborator

I just looked at the code and texture again. The social interactions background has one pixel of black border on the top and left but it has one pixel of white border on the bottom and right. So yes, it looks one pixel off, but I think it's fine as it.

@kevinthegreat1 kevinthegreat1 merged commit cfa71fe into SkyblockerMod:master Jun 2, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants