EssenceShopPrice feature #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your great pr’s. As you may see, we currently have quite a few pr’s awaiting review so this might take a while. |
no worries |
|
Figured I'd drop these here |
|
Also I should probably move the config value over to Item Tooltip in the general category rather than UI & Visuals(don't know what I was thinking here.) |
|
May as well take it to your own visitor pr so they have a child - if you lack essence to buy thing, right clicking would just open bz with needed essence in your clipboard |
kevinthegreat1
added
the
merge conflicts
LifeIsAParadox
removed
the
merge conflicts
This comment was marked as resolved.
This comment was marked as resolved.
Merged
kevinthegreat1
added
changes requested
UpFault
force-pushed
the
EssenceShopCost-Feature
branch
from
579291b
to
4ec9e7d
Compare
LifeIsAParadox
added
merge conflicts
kevinthegreat1
added
the
merge conflicts
…ateFactorySolver to Utils as they most likely will be used many times
Emirlol
force-pushed
the
EssenceShopCost-Feature
branch
from
ce23035
to
54cf91a
Compare
LifeIsAParadox
added
reviews needed
kevinthegreat1
requested changes
Jul 18, 2024
src/main/java/de/hysky/skyblocker/config/configs/GeneralConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/configs/UIAndVisualsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/configs/UIAndVisualsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/configs/UIAndVisualsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/EssenceShopPrice.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/EssenceShopPrice.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/EssenceShopPrice.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/categories/GeneralCategory.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
kevinthegreat1
previously approved these changes
Jul 18, 2024
LifeIsAParadox
added
merge me please
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Jul 18, 2024
LifeIsAParadox
added
merge me please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added option to view how much essence will cost from bazaar in lore of Essence Shop Items