Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisitorHelper Tweak #736

Merged

Conversation

UpFault
Copy link
Contributor

@UpFault UpFault commented May 28, 2024

Re-Based Commit, Moved Feature to separate branch to make it easier to view.

Closed old pull request due to many duplicate pushes being sent by mistake.

all code has been updated/reviewed.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label May 28, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized a pretty big problem with this pr. The copy amount should be per entry, since some visitors may have multiple items. So you can move the item icon in front of the text, then add [Copy Amount] at the end. I can do this if you're not sure what I mean.

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels May 31, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels May 31, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I ended up doing it, and I think it's all good now.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels May 31, 2024
@kevinthegreat1 kevinthegreat1 added new feature This issue or PR is a new feature good first issue Welcome new contributors :) labels May 31, 2024
@kevinthegreat1 kevinthegreat1 merged commit a275c48 into SkyblockerMod:master Jun 2, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Welcome new contributors :) new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants