-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazaar Helper #728
Bazaar Helper #728
Conversation
i would use a traffic light like color thing to say red expired, yellow partially completed and green completely completed personally, but nice already |
I forgot order expiry is a thing, will add red later on. But I don't think partial completion or full completion highlight would help very much. If you claim the currently available items/coins, there's just nothing to for you to do or nothing that requires your attention to the highlighted item but it would still be highlighted. |
i think i wasn't clear when i meant partially completed, i mean items available but not fully completed |
Was planning on adding this, as a secondary highlighting scheme option.
Great idea. I've always checked that manually and was bothered by it, yet the thought of automating it never came to me. Will give it a go. |
Didn't test but looks good. I just realized you're still working on this so marking as wip. |
e7a58f2
to
616f079
Compare
ae1ea28
to
e4fc600
Compare
This doesn't seem to work for Co-ops rn, possibly due to the bazaar screen being named differently depending on solo/co-op profile? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good :)
Actually don't merge until coop is fixed lol. |
Also removes the coloring schema option as that's not relevant anymore. Or rather, there's no reasonable way to display the order type anymore without making the item impossible to see.
Looks good but there's some feedback about there being too much information. I suggested this. |
That's not a bad idea, since you can't do anything to the expiry status without claiming stuff first. |
Also adds some convenience methods to SlotText to make the `SlotTextAdder` logic more readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things if you want to address them.
Highlights orders in the order menu. Gold color if there's coins, or dark green color if there's items to claim
I know the name sounds like it does a lot more than that, but it's just a humble highlighter, I just wanted it to sound cool. Maybe more stuff can be added later on, but I don't have any ideas for now.