Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waypoints #713

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Waypoints #713

merged 10 commits into from
Jun 13, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

Screenshot 2024-05-14 at 23 09 19 Screenshot 2024-05-14 at 23 10 45

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label May 15, 2024
@kevinthegreat1 kevinthegreat1 added new feature This issue or PR is a new feature reviews needed This PR needs reviews and removed reviews needed This PR needs reviews labels May 15, 2024
viciscat
viciscat reviewed May 15, 2024
View reviewed changes
Copy link
Collaborator

@viciscat viciscat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Setting the color input's text color to the inputted color could be swell. More annoying than the rest tho
  • Having a malformatted waypoint or whatever in clipboard and importing will still say "Successfully imported 0 waypoints in 0 categories"

src/main/java/de/hysky/skyblocker/skyblock/waypoint/WaypointsListWidget.java Outdated Show resolved Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/waypoint/WaypointsListWidget.java Show resolved Hide resolved
@kevinthegreat1 kevinthegreat1 added the bleeding edge This PR has been accepted into bleeding edge label May 16, 2024
@kevinthegreat1 kevinthegreat1 mentioned this pull request May 31, 2024
Merged
@kevinthegreat1 kevinthegreat1 added this to the 1.21 milestone Jun 10, 2024
@AzureAaron AzureAaron merged commit 7b288fb into SkyblockerMod:master Jun 13, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the reviews needed This PR needs reviews label Jun 13, 2024
@kevinthegreat1 kevinthegreat1 deleted the waypoint branch June 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat left review comments

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
bleeding edge This PR has been accepted into bleeding edge new feature This issue or PR is a new feature
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinthegreat1 @viciscat @AzureAaron @LifeIsAParadox