Add compact damage #696
Merged
Add compact damage #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
previously requested changes
May 7, 2024
src/main/java/de/hysky/skyblocker/mixins/ClientPlayNetworkHandlerMixin.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
AzureAaron
dismissed
their stale review
Everything looks good now, just waiting on config PR
LifeIsAParadox
added
merge conflicts
Changed formatting method From DecimalFormat to String#formatted to make it easier to configure. Also, the precision setting now applies instantly.
LifeIsAParadox
added
reviews needed
AzureAaron
previously requested changes
May 10, 2024
src/main/java/de/hysky/skyblocker/mixins/ClientPlayNetworkHandlerMixin.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
|
Unfortunately conflicts with another pr, so will be left out of bleeding edge for now. |
LifeIsAParadox
added
reviews needed
AzureAaron
previously approved these changes
May 14, 2024
LifeIsAParadox
added
reviews needed
AzureAaron
approved these changes
May 14, 2024
LifeIsAParadox
added
merge me please
AzureAaron
added
merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortens damage numbers with letters (k, m, b, t). For example, 1234567 would turn into 1.2m. Also allows changing the color of dmg numbers, normal and critical.