-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign calculator #686
Sign calculator #686
Conversation
Another banger by olim. Do you think it would be doable to have an interface that a screen could implement to have it somewhere else? i.e. the popup to set the price/bid in fancy AH. |
This should not be to hard. If the renderSign method in SignCalculator to a location (add possible renamed) then it should work were ever this is called. is this the sort of thing you meant |
add "e" for "enchanted", equals 160 (2.5 stacks) |
yea that's good enough |
Maybe only works if you have a |
src/main/java/de/hysky/skyblocker/skyblock/calculators/SignCalculator.java
Outdated
Show resolved
Hide resolved
good idea. i have added this and put a key in the tooltip so players know its there
i feel like this is a nice idea and some will like it however i like to be reassured what the value of the sign is going to be even if i am just doing something like 1.02k so i have made it a toggle in the settings so both options are available |
last nitpick and I think this PR will be good, add "p" for "purse" maybe? to make it easier and faster to type |
I still don't get how this one would be useful tho |
make it faster to type or something, faster to type "p" than "purse" |
Can you do |
should probaly move to utils function and need to add config and proper text
add command to be able to use the calculator and fix crash with emty equations
added magnitude e as valid. and added to EditBidPopup.
also add key for magnitudes into option tooltip
also fix code a tad
make text for pr in correct order in file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a tiny bug when you have requiresEquals
set to true and type a valid equation without the equals sign. When you add the equals sign, it will show as invalid since the equation is not reevaluated when an equals sign is added, but I don't see a good way of fixing this.
comment / trivial
adds ability to do calculations when inputting number into signs and a calculate command
sign input
command
I have created custom calculator utility for this using a shunting yard algorithm to convert calculation to RPN and then calculating the answer. it also supports (s, k, m, b) and created tests for this.
also tested in game bazaar and ah