Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix item repo NPE #673

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix item repo NPE #673

merged 1 commit into from
Apr 26, 2024

Conversation

AzureAaron
Copy link
Collaborator

Fixes a crash when the NEU repo folder was empty and someone tried to start their game.

@AzureAaron AzureAaron added bug Something isn't working crash This is a crash high priority This issue or PR is prioritized, likely due to a significant loss of a function. labels Apr 26, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Apr 26, 2024
viciscat
viciscat approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea that seems like an important issue

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 26, 2024
@AzureAaron AzureAaron merged commit dcea63d into SkyblockerMod:master Apr 26, 2024
1 check passed
@AzureAaron AzureAaron deleted the fix-item-repo-npe branch April 26, 2024 20:05
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working crash This is a crash high priority This issue or PR is prioritized, likely due to a significant loss of a function.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AzureAaron @viciscat @LifeIsAParadox