Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix item repository update #662

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Fix item repository update #662

merged 1 commit into from
Apr 21, 2024

Conversation

TheDearbear
Copy link
Contributor

Fix item repository update by removing read-only flag when trying to delete repository files

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Apr 20, 2024
@AzureAaron AzureAaron added the bug Something isn't working label Apr 20, 2024
@AzureAaron AzureAaron added this to the 1.20 milestone Apr 20, 2024
@kevinthegreat1
Copy link
Collaborator

Is this needed? The file should be writeable already.

@TheDearbear
Copy link
Contributor Author

On my system, files in the item-repo/.git/objects/pack folder are created with the read-only flag

image

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 21, 2024
@kevinthegreat1 kevinthegreat1 merged commit 95fa171 into SkyblockerMod:master Apr 21, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@TheDearbear @kevinthegreat1 @LifeIsAParadox @AzureAaron