Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix has highest tier #650

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 commented Apr 14, 2024

Fixes highest tier check where previously the mod reported an accessory as has highest tier if the player had the highest tier, regardless of the tier of the accessory.
Adds tier after missing to show what tier the accessory is.

Context: I have the max level Red Claw Artifact

Before

Screenshot 2024-04-14 at 14 21 05

After

Screenshot 2024-04-14 at 15 00 54 Screenshot 2024-04-14 at 15 01 19

@kevinthegreat1 kevinthegreat1 added bug Something isn't working reviews needed This PR needs reviews labels Apr 14, 2024
@AzureAaron AzureAaron added this to the 1.20 milestone Apr 14, 2024
@kevinthegreat1 kevinthegreat1 added the bleeding edge This PR has been accepted into bleeding edge label Apr 17, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 18, 2024
@kevinthegreat1 kevinthegreat1 merged commit 7fa4ac6 into SkyblockerMod:master Apr 19, 2024
1 check passed
@kevinthegreat1 kevinthegreat1 deleted the accessories-fix branch April 19, 2024 14:10
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 19, 2024
@kevinthegreat1 kevinthegreat1 removed the bleeding edge This PR has been accepted into bleeding edge label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants