Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fishing fetures #646

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Conversation

olim88
Copy link
Contributor

@olim88 olim88 commented Apr 11, 2024

This pull request adds the ability to:

  • have a timer above the fishing rod to show how long it has been out for and change color after 20s
  • hide other players fishing rods

these settings are off by default in this pull as some people probably do not want them on

rod timer

image
image

hide other rods

image

give option to show how long a rod has been out for
add option to change the text to green after 20 seconds (use full for some larva fishing)
add option to toggle rendering of other players rods
make sure that the code in the pull request is formatted properly
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Apr 11, 2024
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Apr 11, 2024
@kevinthegreat1
Copy link
Collaborator

Thanks for the pr. Please allow some time for review as we have a high volume of pr's right now. Your pr has been put in bleeding edge, and you can download the newest bleeding edge build here.

@kevinthegreat1 kevinthegreat1 added the bleeding edge This PR has been accepted into bleeding edge label Apr 12, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 16, 2024
@kevinthegreat1 kevinthegreat1 merged commit a2c92d2 into SkyblockerMod:master Apr 16, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 16, 2024
@kevinthegreat1 kevinthegreat1 removed the bleeding edge This PR has been accepted into bleeding edge label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants