Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glacite Mining Updates & Fixes #645

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

AzureAaron
Copy link
Collaborator

@AzureAaron AzureAaron commented Apr 10, 2024

  • Fixes the powder hud not working
  • Add the glacite mineshafts as locations in our two enums & make mineshafts count as being in dwarven mines for our mining features to be active.
  • Adds glacite powder to the powder hud.
  • Recolour the Mithril powder to dark green to align with the tab in game, and because glacite's colour is light blue/aqua.
  • Adds a new dwarven commission and removes an old one that was removed a long time ago.
  • Adds (most of? all of?) the new glacite mining commissions
  • Rename the Ice Walker Slayer commission to Glacite Walker Slayer
  • Refactors the access modifiers of some methods, and rename the client constant to be in line with naming conventions.

Fixes #644.

NB: The classic dwarven hud does not and will not support displaying of glacite powder, the intent is to remove that HUD style as the Simple & Fancy ones offer greater functionality and have a more user intuitive design.

@AzureAaron AzureAaron added bug Something isn't working high priority This issue or PR is prioritized, likely due to a significant loss of a function. labels Apr 10, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Apr 10, 2024
@enbyte
Copy link

enbyte commented Apr 10, 2024

extraordinarily skibidi PR

@notnotmelon
Copy link

W pr

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 10, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Apr 12, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 12, 2024
@kevinthegreat1 kevinthegreat1 merged commit 5041bde into SkyblockerMod:master Apr 12, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 12, 2024
@AzureAaron AzureAaron deleted the glaciate-tunnels branch April 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority This issue or PR is prioritized, likely due to a significant loss of a function.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powder hud no longer functions as of 0.20.0
7 participants