Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ender Nodes Helper #629

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

No description provided.

@kevinthegreat1 kevinthegreat1 added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Apr 3, 2024
@LifeIsAParadox LifeIsAParadox removed the reviews needed This PR needs reviews label Apr 3, 2024
@kevinthegreat1 kevinthegreat1 added the reviews needed This PR needs reviews label Apr 3, 2024
AzureAaron
AzureAaron previously approved these changes Apr 8, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 8, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the waypoint used should be separate from the general config, someone may want beams as a general setting but not on endernodes because it looks kinda bad in the end.

Also being able to see them through walls is a bit too much like an xray, therefore cheating in my opinion

@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews merge conflicts This PR has merge conflicts that need solving. and removed merge me please Pull requests that are ready to merge reviews needed This PR needs reviews labels Apr 8, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Apr 8, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 11, 2024
@kevinthegreat1 kevinthegreat1 merged commit 8de8c71 into SkyblockerMod:master Apr 12, 2024
1 check passed
@kevinthegreat1 kevinthegreat1 deleted the ender-node branch April 12, 2024 14:26
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants